Escape negative numbers in integer-backed enums #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
reviewed
Sep 14, 2023
Sources/_OpenAPIGeneratorCore/Translator/CommonTranslations/translateStringEnum.swift
Outdated
Show resolved
Hide resolved
|
Please add a test case for this as well, just to be positive (ha) that it works. |
simonjbeaumont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #265
Modifications
When handling a negative number, it takes its absolute value and add 'n' before it
Result
Example: "-1" -> "n1"
Test Plan
Ran and passed all the tests