Skip to content

Remove redundant explicit Equatable conformances #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arthurcro
Copy link
Contributor

Motivation

Fixes apple/swift-openapi-generator#210.

Modifications

Types conforming to Hashable do not need to explicity declare that they conform to Equatable.

With this pull request, we are removing the explicit Equatable conformance of types already conforming to Hashable in the code base.

Result

Types conforming to Hashable do explicitly declare a redundant conformance to Equatable.

Test Plan

N/A

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

@czechboy0 czechboy0 enabled auto-merge (squash) August 21, 2023 17:38
@czechboy0 czechboy0 merged commit 4312caf into apple:main Aug 21, 2023
@czechboy0 czechboy0 added the semver/none No version bump required. label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid the explicit Equatable conformance if already conforming to Hashable
2 participants