F!! Remove Catch1 support and add catch2 prefix to all #includes for catch.hpp
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
WARNING: This PR removes support for the Catch 1 unit test framework. See #62 for discussion.
Per the current maintainer for Catch2
Adding
catch2to the path allows ApprovalTests.cpp to work well with the way Catch2 exports target include directories using CMake.The drawback is that there is no simple/clean way to maintain support for Catch 1 without breaking compatibility. Catch 1 is maintained to support C++98. Both ApprovalTests.cpp and Catch2 depend on features of C++11
The following post describes the changes from Catch 1 to Catch 2: https://levelofindirection.com/blog/catch2-released.html
Theses release notes outline the breaking changes from Catch 1 to Catch 2: https://github.com/catchorg/Catch2/releases/tag/v2.0.1