Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullscreen mode #267

Open
pballer2oo7 opened this issue Jan 16, 2017 · 5 comments
Open

fullscreen mode #267

pballer2oo7 opened this issue Jan 16, 2017 · 5 comments

Comments

@pballer2oo7
Copy link
Contributor

I'd like to be able to turn off the Navigation Bar and the Status Bar to take advantage of full screen height, particularly while using approach plates.

The api 19 way of doing it is pretty sweet. Both of the bars autohide but can be pulled up with a swipe near the screen edge.

We can put a check if the system is running api 19 and the user enables the feature. We can set this mode on the view associated with the MainActivity. Nothing changes if the user is running 18 or older or does not enable the feature. Is this an acceptable approach?

If this is done, some other small UI tweaks should be made as well:

  • padding or lowering the TextField on the SearchActivity (because when using stable immersion, the search textfield is partially obscured by status bar when a soft keyboard is raised)
  • present DialogInterfaces in an immersive way (would help with ux fluidity since we're using Dialogs to present lists of choices)
pballer2oo7 added a commit to pballer2oo7/avare that referenced this issue Jan 16, 2017
add 24 dip padding to SearchActivity TextField so that it doesn't get hidden behind status bar during fullscreen operation
@pballer2oo7
Copy link
Contributor Author

pballer2oo7 commented Jan 17, 2017

need to fix WXB, Plan, and List.

When you open one of these tabs fullscreen and then enable the soft keyboard, the keyboard covers up and prevents you from being able to scroll to the bottom of the screen and complete the form.

it's expected behavior due to the webview. see https://code.google.com/p/android/issues/detail?id=5497

couple of options:

  • either stop using webview for these screens and use normal ui widgets that can be reflowed fullscreen with the keyboard (should we do this eventually anyway? what's the reason for using webview for WXB, Plan, and List?),
  • or we can write another solution like this: http://stackoverflow.com/a/19494006

@JohnW4SBA
Copy link
Collaborator

JohnW4SBA commented Jan 17, 2017 via email

@pballer2oo7
Copy link
Contributor Author

I agree completely with you about default behavior, JohnW4SBA. I have it defaulted to off in my branch.

I haven't added any bars or handles. immersive mode does teach the user how to use it (how to recall the bars) the first time it's enabled. we can also add it to the tips and help.

@apps4av
Copy link
Owner

apps4av commented Jan 17, 2017 via email

@pballer2oo7
Copy link
Contributor Author

@apps4av, agreed. I won't open the PR until it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants