-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine weather #492
Open
apps4av
wants to merge
62
commits into
master
Choose a base branch
from
combine-weather
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Combine weather #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release 10.2.4
…om GDL90 message, and use it to drive a configurable display setting to show/hide ground traffic
…affic in audible alerts, using newly exposed boolean of airborne status in traffic object; some post-upstream cleanup/factoring of audible alerts class as well
… knots conversion since new constant introduced)
…k the alert clips prior to the "# seconds" section to give a more accurate time to CPA
…so, allow it to account for different playback speed, if that constant is ever changed or added as a config
…and code refactoring/re-architecting items
…on, as a WIP for providing inner 'cylinder' of incursion for TCPA closing event alerts
…rting audio files)
… over this volume vs. music (per Jeff Ross)
…w audio ready for PR)
…t better than previous
…750ms) as well, to keep alerts distinct and clear
… alerts, as well as the (possible) enclosed closing/TCPA alerts
…in main traffic handling loop
…terfaces other than GDL90 that do not have it)
…ated synch acquisition overhead, and updated one method name for consistency
…eference to support it), and 2.) several small optimizations (factored down method sizes to support inlining and ART native compilation, a smarter producer notification when alerts are running, etc.)
…r on pref's screen
… that matches the configured ownship callsign/tail #
…found to be 0 (previously it left an odd remnant of "within x miles" even though seconds alert was cancelled due to being 0)
…iple traffic items by passing only the new/updated traffic data, not forcing iteration through the whole traffic cache every time when no other traffic changed
…conds as well (having nothing to do with distance)
…true (current system behavior)
…) "point" for decimal distances
…ge parsing and Json-serializing of new fields
…ndencies they had
…ing and execution continuation upon bad user input
Thanks to lots of excellent work by Sam Hoskins, I was inspired to potentially mess that work up by editing it with my own "improvements" since he's on vacation. Presumably before this replaces the in-app Help, he and others will review it further. Even if it's added as-is after ensuring it doesn't somehow mess up the app, I'm confident it's a major improvement on the inconsistent and error-ridden file that has evolved in the years since a last full review. I'm burnt out, and probably won't find time to edit again in the near term. So feel free to munch away at it yourself. I'm going to try attaching Sam's Help-2 file that I've edited.
removed coarse location 10.2.7
update combine-weather branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.