Added view tests for CoursesIndexView #7
Conversation
- Updated the mock model CourseOverview and factory code to provide both 'org' and 'display_org_with_default' and make sure they have the same value when the model instance is created
johnbaldwin
changed the base branch from
john/devsite-and-test-infrastructure
to
develop
| ] | ||
|
|
||
|
|
||
| # Look into renaming 'name' to 'display_name' |
There was a problem hiding this comment.
Looks like you did this, no?
There was a problem hiding this comment.
Not really. The field names in the models may not be the same name as found in the REST API data (defined in the serializer classes, see edx_figures/serializers.py). What I want to do is either remove the need to rename keys (which is unlikely) or find or write some key renaming class or method so I can just pass this as a parameter to model factory constructors instead of an explicit list of named parameters.
| from .factories import CourseOverviewFactory | ||
|
|
||
| # Course data and generate method are duplicates course data in test_filters.py | ||
| COURSE_DATA = [ |
There was a problem hiding this comment.
Maybe throw in some non-ASCII chars to test edge cases
There was a problem hiding this comment.
Good point! I'll add this when I refactor the course index test module. Created issue: #8
| @@ -44,8 +44,15 @@ class CourseOverview(models.Model): | |||
| id = models.CharField(db_index=True, primary_key=True, max_length=255) | |||
| display_name = models.TextField(null=True) | |||
| org = models.TextField(max_length=255, default='outdated_entry') | |||
| # For the tests, the CourseOverviewFactory does a LazyAttribute on | |||
| # display_org_with_default | |||
There was a problem hiding this comment.
Do you want to eventually test that filtering is possible via display org as well as org?
There was a problem hiding this comment.
Yes! Added: #9
|
@bryanlandia Thanks for reviewing! |
…travis Add Juniper Tox environments to TravisCI file
'org' and 'display_org_with_default' and make sure they have the same
value when the model instance is created