Allow brightcove.css styles for VideoJS player v6 to apply universally, size styling fixes for BCove #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ability to upload image handouts * Extend handouts allowed file types list * Refactor uploading file extension check, cover it with unittests
* Reimplement population fields with default values * Cover with unittest 3PlayMedia get_3pm_transcripts_list API failure case * Cover with unittests subdomain fatching utility * Refactor XBLOCK_SETTINGS format * Merge branch 'dev' of https://github.com/raccoongang/xblock-video into 257-configurable-player-id * Fix code review complaints
… (#252) * Add basic "direct" 3PlayMedia transcript functionality * Add proxy transcript fetching handler * Fix unit-tests * Add js 3PlayMedia credentials validation draft * Implement validation handler of 3PlayMedia configuration * Refactor: direct_enabled >> threeplaymedia_streaming * Change threeplaymedia_streaming field scope * Fix typo * Fix code review complaints * Improve test-py coverage * Make utility interface consistent * Fix 3PlayMedia validation handler * Fix exception cases * Fix BrightCove authentication error * Refactor validation of 3PlayMedia options * Fix unicode chars in token error * Remove deprecated 3PlayMedia transcript loading * Add debug logging for default transcripts updating * Refactor 3PlayMedia utilities interface, fix tests, fix quality * Fix variables naming * Add unit test for 3PlayMedia API failure case * Add unit test for 3PlayMedia validation handler: positive test case * Cover with unit tests 3PlayMedia validation handler * Add additional transcripts configuration hint for staff * Refactor error message variable * Refactor Wistia "get_default_transcripts" * Fix UI message to inform users about the absence of transcripts to upload * Handle transcript uploading failure case * Fix Wistia API single transcript downloading URL * Refactor transcript downloading to be performed uniformly with other backends * Fix unit tests: must be simplified * Get rid of unified Wistia Player unit tests * Cover with unit tests Wistia's player.get_default_transcripts * Remove obsolete constant * Revert error details message * Improve undefined-check * Fix code style * Move request arrange test utility to base test module * Extend list of captured exceptions in Wistia transcript downloading method * Cover with unit tests Wistia backend * Make settings.configure globally once * Cover with unit tests Wistia backend (failure case) * Fix unit-tests naming * Cover with unittest wistia_player.get_default_transcripts completely
* Improve enabled transcripts fetching * Add token field to transcripts-related field set * Extend list of errors while handling transcripts * Partially revert field rendering template logic in accordion * Fix unittests, quality * Cover with unittests video_xblock.get_enabled_transcripts * Fix quality complaints
* Fix default&manual transcripts accordion section * Clearify doc strings * Add docstrings to every python test * Remove assertion check, add transcripts terms definitions * Fix minor code review complaints
* Simplify BrightcovePlayer.dispatch() * Cover with unit test Brightcove default transcripts fetching
* Add handouts allowed file type list to README * Describe new XBLOCK_SETTINGS * Describe release changes
…275) * Refactor xBlock fields filling; revert XBLOCK_SETTINGS structure * Fix code quality
- remove arrow button - turn off menu showing on hover
* Make transcripts indexable for LMS search * Fix javascript unit tests
* Normalize retranscode studio editor section * Add Brightcove API retranscode error handling
* Disable native transcripts * Fix potential erroneous spot * Update development deps environment
…lue>', which breaks the authorization header - remove the 'encode' call
….encode('utf-8') - all strings are unicode in python 3, and nothing is gained by encoding them to bytes-representations.
…mplates (#410) Co-authored-by: Glib Glugovskiy <glib.glugovskiy@raccoongang.com>
…estriction EDLY-2810 (#8)
… breaks VideoJS5 but that's getting very old
Must be specified using inline style or class if using % width https://player.support.brightcove.com/styling/sizing-player.html
|
Closed in favor of everything together in #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
The many styles that were made to accommodate changes between Video.js players in v5 series and v6 were done using a .vjs-v6 selector. Remove those so the same styles can apply to subsequent versions. They work well with version 7, which is the major version in use by Brightcove.
https://appsembler.atlassian.net/browse/BLACK-1125
Fixes #27
Rebase off of master once #35 is merged
Type of change
Checklists
Development
Security
Code review