Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 Juniper compatibility, Py3, other fixes #38

Merged
merged 15 commits into from
Aug 9, 2021
Merged

Conversation

bryanlandia
Copy link
Contributor

@bryanlandia bryanlandia commented Aug 5, 2021

Will rebase and Ready for Review after merge of #41

Change description

v1.0.0 release. New major release since it now requires Python 3.

  • Juniper compatibliity

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia bryanlandia marked this pull request as draft August 5, 2021 00:57
@bryanlandia bryanlandia self-assigned this Aug 5, 2021
@bryanlandia bryanlandia marked this pull request as ready for review August 5, 2021 02:47
@bryanlandia
Copy link
Contributor Author

@thraxil I added you as reviewer and feel free if you want, but I need to get @abeals to add some more team members on this repo!

Copy link
Contributor

@thraxil thraxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryanlandia can we split this into mulitple single-purpose PRs? This is way to much to review in one giant chunk.

@bryanlandia
Copy link
Contributor Author

Thanks for taking a look @thraxil. Sure, I'll split it up. Two of them will still be quite large, one is basically just bringing in a lot of changes from Raccoon Gang's fork, another a slew of Py3 changes, and then there are a few other fixes. I'll keep this PR for the version bump then.

@bryanlandia bryanlandia changed the base branch from master to dev August 5, 2021 20:44
@bryanlandia bryanlandia marked this pull request as draft August 5, 2021 20:49
@bryanlandia bryanlandia marked this pull request as ready for review August 6, 2021 18:59
@bryanlandia bryanlandia merged commit 1328a77 into dev Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants