Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: On clicking on the unprotect branch option, all protected branches get unprotected instead of just the current branch. #34005

Closed
1 task done
laveena-en opened this issue Jun 6, 2024 · 1 comment
Closed
1 task done

[Bug]: On clicking on the unprotect branch option, all protected branches get unprotected instead of just the current branch. #34005

laveena-en opened this issue Jun 6, 2024 · 1 comment
Assignees
@brayn003 @riteshkew
Labels
Branch management Issues related to using a branch management on git Bug Something isn't working Git Platform Pod Issues related to the git & the app platform Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production

Comments

@laveena-en
Copy link
Contributor

laveena-en commented Jun 6, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

On clicking on the unprotect branch option, all protected branches get unprotected instead of just the current branch.

Steps To Reproduce

  1. Create a git connected app
  2. Create several branches within it (ex: test, test_1, test_2)
  3. Protect more than one branch say test and test_1
  4. While being on branch test, click on the unprotect branch option
  5. Notice that both test and test_1 get unprotected

Expected behaviour: Only test branch should've been protected

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://www.loom.com/share/0abf8229e45b4b99b3c5da32e5734ff6

Version

v1.26
@laveena-en laveena-en added Bug Something isn't working Production Needs Triaging Needs attention from maintainers to triage Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Branch management Issues related to using a branch management on git labels Jun 6, 2024
@github-actions github-actions bot added Git Platform Pod Issues related to the git & the app platform labels Jun 6, 2024
@laveena-en laveena-en added High This issue blocks a user from building or impacts a lot of users and removed Medium Issues that frustrate users due to poor UX labels Jun 6, 2024
@Nikhil-Nandagopal
Copy link
Contributor

Duplicate of #33310

@Nikhil-Nandagopal Nikhil-Nandagopal marked this as a duplicate of #33310 Jun 11, 2024
@brayn003 brayn003 mentioned this issue Jun 14, 2024
Merged
2 tasks
brayn003 added a commit that referenced this issue Jun 14, 2024
@brayn003
fix: fixing unprotect logic in callout (#34244)
cae0114 
## Description
Clicking "Unprotect branch" in the branch protection callout was making
all the branches as unprotected. This PR fixes that and only allows the
current branch to be unprotected


Fixes #33310  #34005

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9511853863>
> Commit: 1ccab8a
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511853863&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced IDE with advanced branch protection management, including the
ability to unprotect branches directly within the IDE.

- **Bug Fixes**
- Improved handling of current branch filtering to ensure accurate
protected branch management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

@riteshkew riteshkew

Labels
Branch management Issues related to using a branch management on git Bug Something isn't working Git Platform Pod Issues related to the git & the app platform Git Product Issues related to version control product High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nikhil-Nandagopal @brayn003 @riteshkew @laveena-en