Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Widget Selection prompts showing outside Editor #32794

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Apr 19, 2024

Description

When canvas is shown outside the Editor State, we are still showing the canvas with widget selection prompts. Outside the editor, the canvas can be interactable but not selectable.

Fixes #32444

Automation

/ok-to-test tags="@tag.IDE, @tag.Widget, @tag.MobileResponsive, @tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8750634714
Commit: 0ca531f
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Enhanced the Widgets Editor to conditionally display elements based on the current editor state.
    • Improved interaction in the IDE by focusing on widgets only when in the editor state.

@hetunandu hetunandu added the ok-to-test Required label for CI label Apr 19, 2024
Copy link
Contributor

coderabbitai bot commented Apr 19, 2024

Walkthrough

The changes involve implementing state checks using useCurrentAppState and EditorState to conditionally render components and manage interactions based on the IDE's current state. This ensures that interactions like widget focusing and tooltips are appropriately controlled within the editor mode.

Changes

File Path Change Summary
.../CodeModeTooltip.tsx Conditionally renders children if the editor state is EditorState.EDITOR.
.../useHoverToFocusWidget.ts Added state checks to conditionally focus on widgets based on the IDE state, enhancing interaction management.

Assessment against linked issues

Objective Addressed Explanation
Prevent tooltip from showing up in settings (#32444)
Prevent widget interaction in edit mode by checking IDE state (#32138) The changes do not include any mechanism to disable widget interaction as described in the issue.
Address modal widget interaction issues when multiple modals are open (#30653) The PR does not address modal widget interactions or stacking order issues.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added App setting Related to app settings panel within the app Bug Something isn't working IDE Product Issues related to the IDE Product IDE Navigation Issues/feature requests related to IDE navigation, and context switching Low An issue that is neither critical nor breaks a user flow IDE Pod Issues that new developers face while exploring the IDE Release labels Apr 19, 2024
@hetunandu hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 19, 2024
@hetunandu hetunandu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 19, 2024
@hetunandu hetunandu merged commit ad91acd into release Apr 20, 2024
42 checks passed
@hetunandu hetunandu deleted the fix/settings-ide-issues branch April 20, 2024 08:22
@Nikhil-Nandagopal Nikhil-Nandagopal added the Artifact Platform Product Issues related to the application platform label Aug 5, 2024
@github-actions github-actions bot added QA Needs QA attention QA Pod Issues under the QA Pod labels Aug 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal removed IDE Pod Issues that new developers face while exploring the IDE Artifact Platform Product Issues related to the application platform labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App setting Related to app settings panel within the app Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow ok-to-test Required label for CI QA Pod Issues under the QA Pod QA Needs QA attention Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“CMD + Click” Tooltip is showing up in settings
3 participants