Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip of the ellipsis content for response table changed to left position #32800

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Apr 19, 2024

Description

Earlier the position of the tooltip for the ellipsis content was top for which if the content was large it was making it disappear as it appears as the cursor position was displaced from the content and followed on the tooltip which overlapped, hence making the tooltip disappear.

Now the tooltip position is changed to left which restricts the tooltip to appear on the content thereby staying it visible on the screen.

Fixes #32799
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8781850521
Commit: 22a6692
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced command functionality in the code editor with a new button for editing suggestions and updated component styling.
    • Improved tooltip positioning in table displays for better clarity and user experience.
  • Refactor

    • Replaced the Icon component with a Button in the command interface for a more intuitive user interaction.
  • Style

    • Removed specific style definitions to streamline the interface aesthetics.
  • Bug Fixes

    • Adjusted tooltip behavior in the table headers to ensure consistent and accurate information display.

Copy link
Contributor

coderabbitai bot commented Apr 19, 2024

Walkthrough

The recent updates focus on enhancing user interaction and visual feedback within the application. Notable changes include the modification of components for better tooltip management and UI consistency, as well as adjustments to command handling in the editor components for improved usability.

Changes

File Path Change Summary
.../CodeEditor/generateQuickCommands.tsx Replaced Icon with Button, added edit suggestion button, and modified command class name.
.../globalStyles/CodemirrorHintStyles.ts Removed .command-suggestion-edit style definition.
.../Editor/QueryEditor/Table.tsx Modified AutoToolTipComponent usage to include position="left" prop.
.../TableWidget/component/AutoToolTipComponent.tsx Added PopoverPosition import and introduced position prop in Props interface.

Assessment against linked issues

Objective Addressed Explanation
Implement tooltips consistently across various sections of the platform for improved user interaction (#4645)
Ensure tooltips provide clear and concise guidance for actions such as editing, deleting, toggling (#4645)
Fix the blank states for JavaScript and Query components (#31330) Changes focus on tooltip and command enhancements, not on addressing blank states.
Add tooltips for the Add button and Minimize/Maximize buttons (#31330) No modifications related to these specific tooltips were mentioned in the change summaries.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions github-actions bot added Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Papercut a trivially fixable usability bug labels Apr 19, 2024
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8749073374.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32800.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-32800.dp.appsmith.com

@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod Production labels Apr 20, 2024
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8763932197.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32800.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-32800.dp.appsmith.com

@AmanAgarwal041 AmanAgarwal041 added the ok-to-test Required label for CI label Apr 22, 2024
@AmanAgarwal041 AmanAgarwal041 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 22, 2024
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@AmanAgarwal041 AmanAgarwal041 merged commit f281eff into release Apr 22, 2024
42 checks passed
@AmanAgarwal041 AmanAgarwal041 deleted the fix/32799-tooltip branch April 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Papercut a trivially fixable usability bug Production Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tooltip disappears on hover of large cell value in response table
2 participants