[ops][fix]: hardcode APPSMITH_GIT_ROOT value

[pratapaprasanna]

Keeping this open to close exactly after 90 days of merging this PR

[coderabbitai]

Warning

Rate Limit Exceeded

@pratapaprasanna has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 17 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 1e02623 and 1658ac7.

Walkthrough

The recent update involves a modification to the script responsible for setting environment variables. It now ensures that the APPSMITH_GIT_ROOT environment variable is always set to a predefined directory path (/appsmith-stacks/git-storage). Additionally, a warning message has been added to notify users about the deprecation of custom values for APPSMITH_GIT_ROOT.

Changes

File Path	Change Summary
.../fs/opt/appsmith/run-with-env.sh	The script now unconditionally sets the APPSMITH_GIT_ROOT environment variable to /appsmith-stacks/git-storage and ensures the directory is created before executing the command. A warning message has been added to notify users about the deprecation of custom values for APPSMITH_GIT_ROOT.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[sharat87]

As discussed on Slack, can we change the solution to this please?

If there's a custom value configured, we print a warning into the logs. Live with this for ~3months, and then we remove configurability altogather.

So let's just print out a warning message when a custom value for this env variable is defined. Essentially in an else block to the existing if block.

Something like:

WARNING: It appears a custom value has been configured for APPSMITH_GIT_ROOT. This behaviour is deprecated and will soon be removed.

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (1)

deploy/docker/fs/opt/appsmith/run-with-env.sh (1)

Line range hint 7-8: Ensure the paths for sourcing environment variables are valid to prevent runtime errors.

+ if [ ! -f "$ENV_PATH" ] || [ ! -f "$PRE_DEFINED_ENV_PATH" ]; then
+   echo "Error: Environment configuration files not found."
+   exit 1
+ fi

[github-actions]

This PR has been closed because of inactivity.