Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed tabs revamp feature flag #32956

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

albinAppsmith
Copy link
Collaborator

@albinAppsmith albinAppsmith commented Apr 25, 2024

Description

This PR will remove tabs revamp feature flag and make it available for every users.

Fixes #32955

Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8847166703
Commit: 7c27a28
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Removed the feature flag for the IDE tabs revamp, simplifying the rendering logic and component behavior across various IDE components.
    • Streamlined the handling of tabs in the IDE, eliminating conditional feature flag checks and associated conditional rendering.
    • Adjusted test suites to align with the removal of the feature flag, ensuring consistency in component behavior testing.

Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Walkthrough

Walkthrough

The recent updates involve the complete removal of the release_ide_tabs_revamp_enabled feature flag across various components and tests in the codebase. This change simplifies the code by eliminating conditional logic related to the feature flag, thereby streamlining the user interface components and associated logic in the IDE.

Changes

File Path Change Summary
.../FeatureFlag.ts, .../ideSelectors.tsx Removed declarations and selectors for release_ide_tabs_revamp_enabled.
.../FileTabs.test.tsx, .../FileTabs.tsx, .../SplitScreenTabs.tsx, .../StyledComponents.tsx, .../IDESaga.tsx Simplified rendering and logic by removing checks and conditions based on the release_ide_tabs_revamp_enabled flag.

Possibly related issues


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f841e55 and 7c27a28.
Files selected for processing (1)
  • app/client/src/pages/Editor/IDE/EditorTabs/SearchableFilesList.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/Editor/IDE/EditorTabs/SearchableFilesList.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE Task A simple Todo labels Apr 25, 2024
@albinAppsmith albinAppsmith added the ok-to-test Required label for CI label Apr 25, 2024
@github-actions github-actions bot added the Enhancement New feature or request label Apr 25, 2024
@albinAppsmith
Copy link
Collaborator Author

/build-deploy-preview skip-test=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8830429469.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 32956.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-32956.dp.appsmith.com

@albinAppsmith
Copy link
Collaborator Author

/build-deploy-preview skip-test=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8843956614.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 32956.
recreate: .

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
app/client/src/ce/constants/messages.ts (1)

Line range hint 1-1: Consider revising the function START_FROM_TEMPLATE_TITLE to "Start with a template" for better grammatical correctness.

- "Start with template"
+ "Start with a template"

Copy link

Deploy-Preview-URL: https://ce-32956.dp.appsmith.com

@albinAppsmith
Copy link
Collaborator Author

/build-deploy-preview skip-test=true

@albinAppsmith albinAppsmith added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Apr 26, 2024
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8847166250.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 32956.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-32956.dp.appsmith.com

@albinAppsmith albinAppsmith merged commit dfead81 into release Apr 26, 2024
42 checks passed
@albinAppsmith albinAppsmith deleted the remove-tab-feature-flag branch April 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE ok-to-test Required label for CI Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] - Remove tabs revamp feature flag
2 participants