fix: getting outer spacing tokens from theme context.

[marks0351]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #33012
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8874781095
Commit: 9869063
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Updated the method of accessing the theme in the drag-and-drop functionality to enhance consistency and reliability.

[marks0351]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8874728778.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33015.
recreate: .

[coderabbitai]

Walkthrough

Walkthrough

The recent update involves changing the method of accessing theme properties in the useAnvilDnDCompensators function by replacing useTheme with useThemeContext. This adjustment is aimed at resolving issues with highlight positioning in different theming contexts, specifically addressing a bug related to highlight misalignment in various theme densities.

Changes

File Path	Change Summary
.../anvil/editor/canvasArenas/hooks/useAnvilDnDCompensators.ts	Updated import from useTheme to useThemeContext to improve theme context handling.

Assessment against linked issues

Objective	Addressed	Explanation
Highlight positions are correct in Dense and Loose theming (#33012)	❓	It is unclear if the change from useTheme to useThemeContext directly addresses the highlight position issues without additional context on how themes affect positioning.

This assessment focuses strictly on the coding changes related to the objectives mentioned in the linked issues. Further investigation or testing might be required to confirm the full impact of the changes on the application's functionality.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0d03411 and 9869063.

Files selected for processing (1)

• app/client/src/layoutSystems/anvil/editor/canvasArenas/hooks/useAnvilDnDCompensators.ts (2 hunks)

Additional comments not posted (3)

app/client/src/layoutSystems/anvil/editor/canvasArenas/hooks/useAnvilDnDCompensators.ts (3)

3-3: Change of import from useTheme to useThemeContext correctly aligns with the PR's objectives to fix theme context access.

---

12-12: Usage of useThemeContext within the function is correctly implemented to access theme properties.

---

Line range hint 12-34: Ensure the integration of useAnvilDnDCompensators with the rest of the system is tested, especially the new theme context usage and its impact on zIndex and compensator calculations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Deploy-Preview-URL: https://ce-33015.dp.appsmith.com