fix: Create module btn UI fix in split screen view

[albinAppsmith]

Description

Create Module (Beta) button was overlapping on context menu in split screen. This PR addresses this issue.

Fixes #33038

Automation

/ok-to-test tags="@tag.Sanity, @tag.Workflows"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8969352623
Commit: ad38d66
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

[coderabbitai]

Walkthrough

The recent changes involve updates across several files in the API, Explorer, and Query Editor components, focusing on enhancing the UI by integrating new selectors and components to manage the rendering of the ConvertToModuleInstanceCTA based on the editorMode condition. This aligns with efforts to improve UI responsiveness and modularity.

Changes

File Path	Change Summary
.../APIEditor/index.tsx	Added imports and selectors, updated moreActionsMenu for conditional rendering based on editorMode.
.../Explorer/Actions/MoreActionsMenu.tsx	Added imports, updated props interface, and modified menu logic for conditional rendering of additional menus.
.../QueryEditor/index.tsx	Similar changes as in APIEditor/index.tsx, focusing on conditional rendering in moreActionsMenu.

Assessment against linked issues

Objective	Addressed	Explanation
Introduce a new group called "Modules" to the application (#29588)	❓	The changes introduce conditional rendering and modular components, which could indirectly support the new "Modules" group integration by improving UI flexibility.

Possibly related issues

• IA changes #29588: The changes introduce conditional rendering and modular components, which align with the broader goal of enhancing modularity and organization within the application. This could indirectly support the new "Modules" group integration by improving the UI components' flexibility.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[albinAppsmith]

/build-deploy-preview skip-test=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8906632311.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33095.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-33095.dp.appsmith.com

[ashit-rath]

Instead of passing the props here and then within importing the ConvertTModuleInstanceCTA and using there, do you think we should pass the component itself as a prop and name it something like additionalMenuItem?

// Example name
const convertCTA = isSideBySideEnabled && editorMode === EditorViewMode.SplitScreen 
? <ConvertToModuleInstanceCTA {...convertToModuleProps} />
: null

<MoreActionsMenu
          className="t--more-action-menu"
          convertToModuleProps={convertToModuleProps}
          additionalMenuItem={convertCTA}
          ... // other props
          />

{action?.pluginType !== PluginType.INTERNAL &&
       
            // Need to remove this check once workflow query is supported in module
            convertCTA
          }

This way the MoreActionsMenu doesn't need to be aware of a component to import and then apply props to it. What do you think?

[ashit-rath]

I think I wrote the conditions a bit incorrectly as this was a contrived example to show my thought process