Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improving the homepage UI for better user experience #33148

Merged
merged 5 commits into from
May 3, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented May 2, 2024

Description

Improving the homepage UI for better user experience

Fixes #30750 #30747 #30874

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8938008387
Commit: 7f1d282
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@ankitakinger ankitakinger removed the request for review from ayushpahwa May 2, 2024 23:27
Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

Walkthrough

The changes involve refining action types and logic for workspace management within a Redux architecture. This includes removing outdated constants, updating reducer logic for workspace actions, and streamlining workspace operations in sagas. Stylistic improvements have been made to enhance search functionality on both desktop and mobile platforms.

Changes

Files Change Summary
.../ReduxActionConstants.tsx, .../workspaceReducer.ts, .../WorkspaceSagas.ts Updated action types and logic for workspace management. Removed SAVING_WORKSPACE_INFO, introduced SAVE_WORKSPACE_INIT, and adjusted related saga and reducer logic.
.../DesktopEntitySearchField.tsx, .../MobileEntitySearchField.tsx Added new styles for .search-loader to enhance UI in search components.
.../ce/actions/workspaceActions.ts, .../ce/constants/ReduxActionConstants.tsx Removed searchWorkspaceEntitiesLoader function and SAVING_WORKSPACE_INFO constant.
.../ce/pages/Applications/index.tsx Adjusted top margin in ApplicationsWrapper based on visibility and device type.
.../ce/pages/common/WorkflowSearchItem.tsx Renamed searchedWorkflows to workflowsList.
.../ce/selectors/workspaceSelectors.tsx Added getSearchedWorkflows function.
.../pages/common/PageHeader.tsx Modified styling logic in StyledPageHeader component.
.../pages/common/SearchBar/EntitySearchBar.tsx Revised search input handling and results logic.

Assessment against linked issues

Objective Addressed Explanation
Reorganize the top bar layout with specific changes as detailed in the issue #29954 The PR focuses on workspace management and search functionality enhancements, not top bar layout reorganization as specified in the issue.
Fix the missing pencil icon issue described in issue #30750 The PR does not address the specific issue related to the missing pencil icon in the three-dot dropdown menu as described.
Enhance the UI experience as part of the broader frontend updates mentioned in issue #28789 The PR indirectly enhances the UI experience by improving search functionality and workspace management UI elements, aligning with the broader frontend updates mentioned in the issue. Further validation may be needed to confirm alignment.

Possibly related issues

  • appsmithorg/appsmith#28789: The PR changes could indirectly enhance the UI experience as part of the broader frontend updates mentioned in the issue, particularly improving search functionality and workspace management UI elements.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7f1d282 and da674c1.
Files selected for processing (1)
  • app/client/src/ce/pages/common/WorkflowSearchItem.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/ce/pages/common/WorkflowSearchItem.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankitakinger ankitakinger changed the title Fix/homepage UI ux issues fix: Improving the homepage UI for better user experience May 3, 2024
@github-actions github-actions bot added the Bug Something isn't working label May 3, 2024
@ankitakinger ankitakinger added the ok-to-test Required label for CI label May 3, 2024
@github-actions github-actions bot added Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers Home Page Issues related to the application home page Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production labels May 3, 2024
@ankitakinger ankitakinger requested review from brayn003 and ashit-rath and removed request for brayn003 May 3, 2024 12:41
Copy link
Contributor

@brayn003 brayn003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change looks good to me otherwise

@ankitakinger ankitakinger requested a review from brayn003 May 3, 2024 12:55
@trishaanand trishaanand merged commit 447e78a into release May 3, 2024
15 checks passed
@trishaanand trishaanand deleted the fix/homepage-ui-ux-issues branch May 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers Bug Something isn't working Home Page Issues related to the application home page Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pencil icon isn't seen on trying to rename a workspace from the three dot dropdown menu.
3 participants