Force a prompt if PS1
is empty entering a container.
#5647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
If a container without a
.singularity.d
is run then there is noenvironment file to set a custom
PS1
.If additionally singularity is called through a script, which will reset
PS1 to empty, then a confusing silent prompt will result.
In our action script force PS1 to a default if it is empty.
This results in the example given in #5340 producing a prompt as expected:
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make testall
Attn: @singularity-maintainers