Skip to content

Conversation

christyjacob4
Copy link
Contributor

@christyjacob4 christyjacob4 commented Jan 16, 2025

What does this PR do?

  • Ensure the project attribute in the jobs payloads contains only the necessary attributes
  • Add a new delete type maintenance to prevent the maintenance worker from triggering multiple jobs for performing maintenance on the same project.

Previously the maintenance worker triggered the following delete jobs for each project

  • DELETE_TYPE_SESSIONS
  • DELETE_TYPE_EXECUTIONS
  • DELETE_TYPE_AUDIT
  • DELETE_TYPE_USAGE
  • DELETE_TYPE_EXPIRED_TARGETS
    So if you had 1000 projects, it would trigger 5000 jobs and overwhelm the queue.

Now, instead it triggers a single job of type DELETE_TYPE_MAINTENANCE and the deletes worker handles all the deletions. Thereby triggering only 1000 jobs

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

github-actions bot commented Jan 16, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

github-actions bot commented Jan 16, 2025

✨ Benchmark results

  • Requests per second: 1,023
  • Requests with 200 status code: 184,209
  • P99 latency: 0.178189858

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,023 1,608
200 184,209 289,440
P99 0.178189858 0.072591008

@christyjacob4 christyjacob4 merged commit 1b53df4 into 1.6.x Jan 17, 2025
63 checks passed
@christyjacob4 christyjacob4 deleted the chore-optimise-events-payloads branch January 17, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants