Skip to content

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

It seems the Variable's selectedVar was always null when updating a variable. This update makes the Variable match the wizard:

{#if showCreate}
<Create
bind:selectedVar
bind:showCreate
on:created={handleCreated}
on:updated={handleUpdated} />
{/if}

to ensure the correct selectedVar is passed.

There is also a bug here were you can't create a variable after attempting to update a variable, but that should be fixed by:

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Nov 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
console ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 7:16PM (UTC)

@TorstenDittmann TorstenDittmann merged commit 48dde69 into main Nov 22, 2022
@TorstenDittmann TorstenDittmann deleted the fix-4743-update-function-variables branch November 22, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Editing of function variables does not work
3 participants