Improve DNS changes copy #2293
Improve DNS changes copy #2293
Conversation
ConsoleProject ID: Sites (2)
Note You can use Avatars API to generate QR code for any text or URLs. |
WalkthroughThis change updates user-facing text related to DNS propagation across several Svelte components. In nameserverTable.svelte and two recordsCard.svelte files, the note now specifies that changes may take up to 48 hours to propagate fully, replacing a generic propagation time message. The retryDomainModal.svelte guidance text was similarly updated to mention the 48-hour window. No logic, data flow, APIs, or layout were modified; only static copy within UI components was changed. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/routes/(console)/organization-[organization]/domains/recordsCard.svelte (1)
87-89: Minor copy polish for clarityConsider switching “on your DNS provider” to “with your DNS provider” for more natural phrasing. Also keep the sentence on one line to avoid accidental whitespace in translations.
- Add the following nameservers on your DNS provider. Note that changes may take up to - 48 hours to propagate fully. + Add the following nameservers with your DNS provider. Note that changes may take up to 48 hours to propagate fully.src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (1)
67-69: Minor copy polish for consistencySame phrasing tweak here to match other surfaces and improve readability.
- Add the following nameservers on your DNS provider. Note that changes may take up to 48 - hours to propagate fully. + Add the following nameservers with your DNS provider. Note that changes may take up to 48 hours to propagate fully.src/lib/components/domains/nameserverTable.svelte (1)
26-28: Minor copy polish; consider centralizing shared string
- Use “with your DNS provider” for more natural phrasing.
- Optional: centralize this 48-hour guidance in a shared constant/translation key to avoid future drift across components.
- Add the following nameservers on your DNS provider. Note that changes may take up to 48 - hours to propagate fully. + Add the following nameservers with your DNS provider. Note that changes may take up to 48 hours to propagate fully.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
src/lib/components/domains/nameserverTable.svelte(1 hunks)src/routes/(console)/organization-[organization]/domains/recordsCard.svelte(1 hunks)src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte(1 hunks)src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: e2e
| Add the following nameservers on your DNS provider. Note that changes may take | ||
| up to 48 hours to propagate fully. | ||
| </Typography.Text> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Incorrect instruction: mentions “nameservers” but the table shows a CNAME record
This UI asks users to add “nameservers” while the table below instructs them to add a CNAME. That can mislead users and delay verification.
- Add the following nameservers on your DNS provider. Note that changes may take
- up to 48 hours to propagate fully.
+ Add the following CNAME record with your DNS provider. Note that changes may take up to 48 hours to propagate fully.Run to find any other mismatches between the “nameservers” phrasing and non-NS records:
🏁 Script executed:
#!/bin/bash
# Show all occurrences of the phrase with nearby context
rg -nC3 -S 'Add the following nameservers' --type svelte
# Confirm this screen indeed uses CNAME
rg -nC2 -S 'CNAME' --type svelte 'src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte'
# Check all places using the 48-hour copy for consistency
rg -n -S 'up to 48 hours' --type svelteLength of output: 333
#!/bin/bash
# Find all occurrences of the “nameservers” phrasing in Svelte files
grep -R -n -C3 "Add the following nameservers" --include="*.svelte" .
# Confirm CNAME usage in this specific component
grep -R -n -C2 "CNAME" --include="recordsCard.svelte" src/routes/(console)/project-*/project/functions/function-*/domains/
# Check all instances of the 48-hour copy for consistency
grep -R -n "up to 48 hours" --include="*.svelte" .#!/bin/bash
# Locate the “nameservers” phrasing in all Svelte files
grep -R -n -C3 "Add the following nameservers" --include="*.svelte" .
# Verify CNAME usage in recordsCard.svelte
grep -R -n -C2 "CNAME" --include="recordsCard.svelte" src/routes/(console)/project-*/project/functions/function-*/domains/
# Check every Svelte file for the “up to 48 hours” text
grep -R -n "up to 48 hours" --include="*.svelte" .🏁 Script executed:
#!/bin/bash
# Locate the “nameservers” phrasing in all Svelte files
grep -R -n -C3 "Add the following nameservers" --include="*.svelte" .
# Verify CNAME usage in recordsCard.svelte
grep -R -n -C2 "CNAME" --include="recordsCard.svelte" src/routes/(console)/project-*/project/functions/function-*/domains/
# Check every Svelte file for the “up to 48 hours” text
grep -R -n "up to 48 hours" --include="*.svelte" .Length of output: 3953
Replace “nameservers” with “CNAME record” in CNAME instructions
-
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte (line 28): change
“Add the following nameservers on your DNS provider. Note that changes may take up to 48 hours to propagate fully.”
to
“Add the following CNAME record with your DNS provider. Note that changes may take up to 48 hours to propagate fully.” -
src/routes/(console)/organization-[organization]/domains/recordsCard.svelte (line 87): apply the same replacement.
-
src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte (line 67): apply the same replacement.
Leave src/lib/components/domains/nameserverTable.svelte unchanged (it correctly refers to NS records).
🤖 Prompt for AI Agents
In
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
around lines 28-30,
src/routes/(console)/organization-[organization]/domains/recordsCard.svelte
around line 87, and
src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte
around line 67, replace the phrase “Add the following nameservers on your DNS
provider. Note that changes may take up to 48 hours to propagate fully.” with
“Add the following CNAME record with your DNS provider. Note that changes may
take up to 48 hours to propagate fully.”; ensure exact punctuation and
capitalization match the replacement and do not modify
src/lib/components/domains/nameserverTable.svelte (it correctly refers to NS
records).
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit