Skip to content

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Sep 17, 2025

What does this PR do?

Functions deployment card was using gap="xxl"

Test Plan

image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

yes

Summary by CodeRabbit

  • Style
    • Reduced vertical spacing within the Deployment card in the Functions view, creating a more compact, easier-to-scan layout.
    • Improves information density without altering functionality or interactions.
    • Visual polish only; no behavioral changes or new settings required.
    • Applies to the function detail page within the project console, enhancing overall consistency with other cards and layouts.

Copy link

appwrite bot commented Sep 17, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

Appwrite has a Discord community with over 16 000 members.

Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Walkthrough

  • Updated src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte.
  • Modified the Layout.Stack gap prop inside a Card from "xxl" to "l".
  • No changes to logic, control flow, or rendering structure beyond spacing.
  • No updates to exported/public entity signatures.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "fix: changed gap from xxl to l" directly and succinctly describes the primary change in the changeset — adjusting the gap value from "xxl" to "l" in the deployment card component — so it accurately reflects the main change and is specific enough for teammates scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-SER-398-Fix-spacing-functions-deployment-card

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte (1)

188-196: Avoid hard‑coded full‑bleed hack using -1 * var(--space-9).

This couples layout to a specific space token and may drift from Card padding="m". Prefer a token/utility that matches Card’s horizontal padding or a built‑in full‑bleed pattern if Pink provides one.

Verify whether Pink offers a fullWidth/inset/bleed prop or a matching CSS var for Card padding to replace --space-9.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c574824 and aa05f9f.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte (1)

81-81: Gap change to "l" looks good; scoped impact is correct.

Top-level Stack has two children only when footer is present, so this reduces spacing specifically above the footer block—aligned with the PR intent.

Please sanity‑check:

  • Confirm gap="l" is a valid Pink token for Layout.Stack.
  • Visually QA at sm/md/lg breakpoints with and without footer, ensuring the Divider doesn’t feel cramped.
  • Check long titles/IDs wrapping in the header don’t collide with the tightened footer spacing.

@Meldiron Meldiron merged commit 567bf90 into main Sep 17, 2025
5 checks passed
@Meldiron Meldiron deleted the fix-SER-398-Fix-spacing-functions-deployment-card branch September 17, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants