-
Notifications
You must be signed in to change notification settings - Fork 189
fix: changed gap from xxl to l #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed gap from xxl to l #2380
Conversation
ConsoleProject ID: Sites (2)
Note Appwrite has a Discord community with over 16 000 members. |
Walkthrough
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte (1)
188-196
: Avoid hard‑coded full‑bleed hack using-1 * var(--space-9)
.This couples layout to a specific space token and may drift from
Card
padding="m". Prefer a token/utility that matches Card’s horizontal padding or a built‑in full‑bleed pattern if Pink provides one.Verify whether Pink offers a
fullWidth
/inset
/bleed
prop or a matching CSS var for Card padding to replace--space-9
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e
- GitHub Check: build
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/deploymentCard.svelte (1)
81-81
: Gap change to "l" looks good; scoped impact is correct.Top-level Stack has two children only when
footer
is present, so this reduces spacing specifically above the footer block—aligned with the PR intent.Please sanity‑check:
- Confirm
gap="l"
is a valid Pink token forLayout.Stack
.- Visually QA at sm/md/lg breakpoints with and without
footer
, ensuring the Divider doesn’t feel cramped.- Check long titles/IDs wrapping in the header don’t collide with the tightened footer spacing.
What does this PR do?
Functions deployment card was using gap="xxl"
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit