Skip to content

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Sep 29, 2025

What does this PR do?

clean up Topics empty state in message view:

Test Plan

image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

yues

Summary by CodeRabbit

  • Style

    • Replaced the “no topics” fallback with a new card-based empty state, showing a clearer title, description, and a Documentation button for guidance.
    • Aligns visuals with the latest design system for a more consistent experience.
  • Refactor

    • Standardized the empty-state implementation by replacing the legacy empty component with the new design system component.

Copy link

appwrite bot commented Sep 29, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

Cursor pagination performs better than offset pagination when loading further pages.

Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Walkthrough

The “no topics” UI in src/routes/(console)/project-[region]-[project]/messaging/message-[message]/updateTopics.svelte was changed from using EmptySearch (from $lib/components) to a PinkEmpty card placed inside Card.Base from @appwrite.io/pink-svelte. The new UI includes a title, description, and a Documentation button in the actions slot. Imports were updated: added Card and Empty as PinkEmpty from @appwrite.io/pink-svelte and removed the EmptySearch import. All other control flow and states (draft vs non-draft) remain unchanged.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “fix Messaging Topics empty state” succinctly captures the primary change, which is updating the UI for the “no topics” case in the messaging view, and uses clear, descriptive language that a teammate can quickly understand when scanning the project history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-Messaging-Topics-Empty-State

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee22b9a and af4d81f.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/messaging/message-[message]/updateTopics.svelte (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (2)
src/routes/(console)/project-[region]-[project]/messaging/message-[message]/updateTopics.svelte (2)

3-4: Imports updated cleanly
Swapping in the pink-svelte Card/PinkEmpty keeps this view consistent with the rest of the console components.


143-157: Improved non-draft empty state
The past-tense copy and docs CTA fit the post-delivery context, and the PinkEmpty treatment aligns with the design system.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ItzNotABug ItzNotABug merged commit 51929b7 into main Sep 29, 2025
5 checks passed
@ItzNotABug ItzNotABug deleted the fix-Messaging-Topics-Empty-State branch September 29, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants