Skip to content

fix: resolve popover z-index stacking in settings cards #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix: resolve popover z-index stacking in settings cards #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/components/cardGrid.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@

export let hideFooter = false;
export let gap: 'none' | 'xxxs' | 'xxs' | 'xs' | 's' | 'm' | 'l' | 'xl' | 'xxl' | 'xxxl' = 'l';
export let style = '';
export let zIndex: number | undefined = undefined;
</script>

<Card.Base>
<Card.Base style="{zIndex !== undefined ? `position: relative; z-index: ${zIndex};` : ''} {style}">
<Layout.Stack gap="xl" justifyContent="space-around">
<Layout.GridFraction gap="xxxl" rowGap="xl" start={1} end={2}>
<Layout.Stack gap="xxs">
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/settings/updateInstallations.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
}
</script>

<CardGrid>
<CardGrid zIndex={10}>
<svelte:fragment slot="title">Git configuration</svelte:fragment>
Add a Git installation to your project so you can connect repositories later through your function
or site settings.
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/updateVariables.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@
: false;
</script>

<CardGrid>
<CardGrid zIndex={10}>
<svelte:fragment slot="title"
>{isGlobal ? 'Global variables' : 'Environment variables'}</svelte:fragment>
{#if isGlobal}
Expand Down