This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Feat realtime updates #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
approved these changes
Feb 14, 2022
| @@ -167,12 +194,24 @@ subscription.stream.listen((response) { | |||
| <li> | |||
| <h3>Android</h3> | |||
| <div class="ide margin-bottom" data-lang="android" data-lang-label="Android SDK"> | |||
| <pre class="line-numbers"><code class="prism language-kotlin" data-prism>val client = Client() | |||
| <pre class="line-numbers"><code class="prism language-kotlin" data-prism>val client = Client(context) | |||
There was a problem hiding this comment.
have we updated everywhere that client requires context in android?
There was a problem hiding this comment.
@abnegate rest looks good to me, just verify that we have not missed anywhere that android client requires context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.