Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

gewenyu99
Copy link
Contributor

This fixes errors for Android and Flutter.

For Android:

  • Fixes the use of single quotes for strings

For Flutter

  • Missing semicolon
  • Use of triple equal sign ===, which is no longer supported.

Copy link
Contributor

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewenyu99 I noticed there are more instances in the same file where we're using single quotes for strings in kotlin. Please fix those as well.

Also take a look at the entire flutter file too

Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android/Kotlin examples should also use == (structural equality) instead of === (referential equality) for these cases

@gewenyu99
Copy link
Contributor Author

@gewenyu99 I noticed there are more instances in the same file where we're using single quotes for strings in kotlin. Please fix those as well.

Also take a look at the entire flutter file too

Addressed. Fixed all === usages and added ; where applicable

The Android/Kotlin examples should also use == (structural equality) instead of === (referential equality) for these cases

Replaced with structural equality :)

@gewenyu99
Copy link
Contributor Author

Android:
Screen Shot 2022-05-09 at 10 03 36 AM

Flutter
Screen Shot 2022-05-09 at 10 15 38 AM

@TorstenDittmann TorstenDittmann merged commit 57e35a7 into main May 12, 2022
@TorstenDittmann TorstenDittmann deleted the fix-getting-started-examples branch May 12, 2022 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants