Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

gewenyu99
Copy link
Contributor

Realtime events have changed in 0.14 and examples need to be updated for 0.14.

@gewenyu99 gewenyu99 requested a review from Meldiron May 31, 2022 00:58
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Make sure these are manually tested, but overall syntax looks fine.

</td>
<td data-title="Description: ">
The <a href="/docs/webhooks#events">system event</a> that triggered this update.
The <a href="/docs/webhooks#events">system events</a> that triggered this update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we only have events documented under webhooks? How do people using Functions learn about all the events? This might be a concern for separate task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to review this. Let me open a separate task for this.

@gewenyu99 gewenyu99 requested a review from Meldiron May 31, 2022 18:19
@gewenyu99 gewenyu99 merged commit 750151d into main May 31, 2022
@gewenyu99 gewenyu99 deleted the update-realtime-examples branch June 3, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants