-
Notifications
You must be signed in to change notification settings - Fork 116
Add .NET, Kotlin, Java function examples to Functions Guide #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After applying these, please double-check if they still work. We might have a bug in open-runtimes if these changes don't work. (payload should always default to empty string)
I think this looks alright, I have no comments on the code itself, mainly because I don't know kotlin or C# well. I would think adding some comments might be useful. It depends on the language, but we should at least comment on what the function is supposed to do in a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding some comments so the code is easier to follow. I say this mostly because I don't know these languages very well, and I subconsciously started looking for a comment.
That's actually not been across any of the samples. Maybe something we should have across them all? |
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
@Meldiron I removed the check for
Could this be the Console sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@adityaoberai don't worry about Payload (should, and) will be empty string if not provided. |
Sure 👍 |
@gewenyu99 maybe this could be an entirely separate issue of it's own that we could work on? I'll go ahead and create one in the meantime. |
app/views/docs/functions.phtml
Outdated
}</code></pre> | ||
</div> | ||
<p><b>Installing Dependencies</b></p> | ||
<p>Include a <b>Function.csproj</b> file in your function, Appwrite handles the rest!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Include a <b>Function.csproj</b> file in your function, Appwrite handles the rest!</p> | |
<p>Include a <b>Function.csproj</b> file with your function - Appwrite handles the rest!</p> |
I saw that some of the existing functions also use in
and a comma.
Please update those as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that 👍
I was following suit, to be honest.
app/views/docs/functions.phtml
Outdated
}</code></pre> | ||
</div> | ||
<p><b>Installing Dependencies</b></p> | ||
<p>Include a <b>deps.gradle</b> file in your function, Appwrite handles the rest!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Include a <b>deps.gradle</b> file in your function, Appwrite handles the rest!</p> | |
<p>Include a <b>deps.gradle</b> file with your function - Appwrite handles the rest!</p> |
Likewise
app/views/docs/functions.phtml
Outdated
}</code></pre> | ||
</div> | ||
<p><b>Installing Dependencies</b></p> | ||
<p>Include a <b>deps.gradle</b> file in your function, Appwrite handles the rest!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>Include a <b>deps.gradle</b> file in your function, Appwrite handles the rest!</p> | |
<p>Include a <b>deps.gradle</b> file in your function - Appwrite handles the rest!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments
@christyjacob4 made the grammatical (+ a couple of other minor ones I saw) |
Adds a .NET, Kotlin, and Java function examples to the Writing your own Function section in the Functions guide.