Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

gewenyu99
Copy link
Contributor

@gewenyu99 gewenyu99 commented Jun 7, 2022

There are no examples of how to use the database orderBy functionality. The explanation is not trivial and does not fit on the API docs, so I added it to the database guide.

I also updated some of the other examples, because they were using single quotes for strings for languages that expect a double quote.

@gewenyu99
Copy link
Contributor Author

Screen Shot 2022-06-08 at 1 44 46 PM

@gewenyu99 gewenyu99 marked this pull request as ready for review June 8, 2022 17:47
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update screenshots for easier review after changes we made.

@gewenyu99
Copy link
Contributor Author

LGTM. Please update screenshots for easier review after changes we made.

I could not get a render for some reason >:(

When I updated the branch, I checked the vendor folder, which pulled the correct branch, but the built container is not updating correctly. I'm gonna ask you tmr :P

@gewenyu99
Copy link
Contributor Author

Screen Shot 2022-06-21 at 11 11 57 AM

Screen Shot 2022-06-21 at 11 11 53 AM

@gewenyu99 gewenyu99 requested a review from Meldiron June 21, 2022 16:05
@gewenyu99
Copy link
Contributor Author

@Meldiron Added comments

@gewenyu99
Copy link
Contributor Author

Screen Shot 2022-06-21 at 12 19 26 PM

@gewenyu99 gewenyu99 merged commit e20a1d1 into main Jun 22, 2022
@gewenyu99 gewenyu99 deleted the add-order-documentation branch July 10, 2022 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants