This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Feat disable rate limiting #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Jul 12, 2022
added 2 commits
July 14, 2022 16:46
|
|
stnguyen90
approved these changes
Jul 14, 2022
eldadfux
reviewed
Jul 17, 2022
app/views/docs/rate-limits.phtml
Outdated
|
|
||
| <h2><a href="/docs/rate-limits#disable-limits" id="disable-limits">Disable Rate Limits</a></h2> | ||
| <p>During development, you may need to frequently make requests to certain endpoints to test your code. You can temporarily disable rate limiting to prevent triggering rate limits during development.</p> | ||
| <p>You can disable rate limiting by setting <span class="tag">_APP_OPTIONS_ABUSE</span> to <span class="tag">disabled</span> in the <b>.env</b> file found in your Appwrite install directory.</p> |
There was a problem hiding this comment.
I think this section can be shorter and just refer to the env variables doc, instead of trying to re-explain how to update them. We also miss information on recreating the Appwrite container in the last paragraph, which is maybe another hint to move this info to the relevant page.
We should also have a self-hosted only reminder when Cloud goes live.
|
@eldadfux Addressed your comments. We can disabled the whole section when Cloud roles around. |
christyjacob4
approved these changes
Jul 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs to disable rate limiting.