Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Fix web SDK syntax #226

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Fix web SDK syntax #226

merged 3 commits into from
Aug 2, 2022

Conversation

stnguyen90
Copy link
Contributor

Update Web SDK code for 0.15 syntax.

@stnguyen90 stnguyen90 requested a review from gewenyu99 July 19, 2022 23:55
gewenyu99
gewenyu99 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I like it. I think I want to discuss how we use bold vs span tag vs quotes to reference files, code, environment variables, and URLs. This will probably happen in the formatting PR that's coming after terminology guidelines.

@stnguyen90 stnguyen90 merged commit 96e3e3d into main Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@gewenyu99 gewenyu99 gewenyu99 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @gewenyu99