Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

gewenyu99
Copy link
Contributor

@gewenyu99 gewenyu99 commented Sep 26, 2022

What does this PR do?

This PR:

  • Redistributes best practices organically
  • Improves styling for session information
  • Reorders index on the left side

Screen Shot 2022-09-28 at 6 53 59 PM

Screen Shot 2022-09-28 at 6 54 20 PM

Screen Shot 2022-09-28 at 6 54 52 PM

Screen Shot 2022-09-28 at 6 55 49 PM

Screen Shot 2022-09-28 at 6 56 46 PM

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Co-authored-by: Jake Barnby <jakeb994@gmail.com>
@gewenyu99 gewenyu99 requested a review from abnegate September 27, 2022 20:39
@gewenyu99
Copy link
Contributor Author

Thanks @abnegate , how about now?

@gewenyu99 gewenyu99 changed the title Fix Auth list font Authentication Guide Improvements Sep 28, 2022
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change look good, left two comments.

@gewenyu99
Copy link
Contributor Author

@eldadfux @abnegate Addressed comments :)

@eldadfux eldadfux merged commit 1b1b328 into main Sep 30, 2022
@gewenyu99 gewenyu99 deleted the fix-auth-list-font branch October 4, 2022 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants