-
Notifications
You must be signed in to change notification settings - Fork 115
Update the SDK and Version dropdowns to include location hash #276
Conversation
This does preserve location for the most part. When we change the name of endpoints, it'll jump back to the top of the page because there's no matching hash, which is fine. It works really well when I switch SDKs, which is great. Now the real question is, since we're already adding JS, who don't we track scroll location? |
@gewenyu99, that seems much higher effort 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on homepage, works great. Idk if the implementation is optional, I'll leave it to engineering to decide :)
8e9d57d
to
d229afb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again, lgtm
Would love to get some more context are a short example to fully understand the new suggested behavior. |
@eldadfux, I've updated the description. |
@stnguyen90 The scroll bars look so weird there! is this what it looks like on windows? |
What does this PR do?
Update the SDK and Version dropdowns to include location hash. Prior to this, if you:
You would jump to the top of the page instead of still being on the Get Document API.
Screen.Recording.2022-10-24.at.8.48.18.AM.mov
After this, you would stay on the API you last clicked on after switching the version or SDK.
Test Plan
Manual
Related PRs and Issues
Based off the following PR:
Have you read the Contributing Guidelines on issues?
Yes