-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Dart SDK update for version 19.1.0 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughVersion bumped to 19.1.0 in pubspec and client headers/SDK metadata. CHANGELOG updated for 19.1.0. Account service: added createEmailVerification (POST /account/verifications/email) and updateEmailVerification (PUT /account/verifications/email); deprecated createVerification and updateVerification; phone verification endpoints moved to /account/verifications/phone. README Dart dependency updated to ^19.1.0. New docs/examples for email verification added. Documentation links updated in functions, sites, and tables_db. Tests added for the new email verification methods. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (1)
5-7
: Document all Account verification changes.We added
updateEmailVerification
and shifted verification endpoints to the/account/verifications/*
paths, yet the 19.0.1 notes only mention deprecatingcreateVerification
and addingcreateEmailVerification
. Please call out the newupdateEmailVerification
method (and optionally the endpoint migration) so developers aren’t surprised by the API surface change.## 19.0.1 * Deprecate `createVerification` method in `Account` service * Add `createEmailVerification` method in `Account` service +* Add `updateEmailVerification` method in `Account` service and migrate verification endpoints to `/account/verifications/*`
lib/services/account.dart (1)
1238-1263
: Update doc link to match the new API name
The doc string forcreateEmailVerification
still links to#updateVerification
, which now refers to a deprecated API. Pointing it to#updateEmailVerification
will keep the docs consistent and avoid confusing consumers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
CHANGELOG.md
(1 hunks)README.md
(1 hunks)docs/examples/account/create-email-verification.md
(1 hunks)docs/examples/account/update-email-verification.md
(1 hunks)lib/services/account.dart
(4 hunks)lib/services/functions.dart
(1 hunks)lib/services/sites.dart
(1 hunks)lib/services/tables_db.dart
(5 hunks)lib/src/client_browser.dart
(1 hunks)lib/src/client_io.dart
(1 hunks)pubspec.yaml
(1 hunks)test/services/account_test.dart
(2 hunks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
CHANGELOG.md
(1 hunks)README.md
(1 hunks)lib/src/client_browser.dart
(1 hunks)lib/src/client_io.dart
(1 hunks)pubspec.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pubspec.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- lib/src/client_browser.dart
- README.md
🔇 Additional comments (1)
lib/src/client_io.dart (1)
39-41
: LGTM! Version metadata correctly updated.The SDK version and user-agent headers have been correctly updated to 19.1.0, consistent with the PR objectives.
* Deprecate `createVerification` method in `Account` service | ||
* Add `createEmailVerification` method in `Account` service | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the updateEmailVerification addition
The 19.1.0 entry mentions only the new createEmailVerification method, but the PR also adds updateEmailVerification
. Please document that addition (and any related endpoint shifts) here so the changelog accurately reflects the release contents.
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 5 to 7, the 19.1.0 changelog only lists the new
createEmailVerification method but omits the added updateEmailVerification and
any endpoint changes; update the 19.1.0 entry to include a line documenting the
added updateEmailVerification method and note any related endpoint shifts (e.g.,
renamed or moved endpoints) so the changelog accurately reflects both
createEmailVerification and updateEmailVerification additions and their endpoint
implications.
This PR contains updates to the Dart SDK for version 19.1.0.
Summary by CodeRabbit