-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor bugs #97
Merged
Merged
fix: minor bugs #97
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: Publish to NPM | ||
|
||
on: | ||
release: | ||
types: [published] | ||
workflow_dispatch: | ||
|
||
jobs: | ||
publish: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
# Setup Node.js environment | ||
- name: Use Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20.x' | ||
registry-url: 'https://registry.npmjs.org' | ||
|
||
# Determine release tag based on the tag name | ||
- name: Determine release tag | ||
id: release_tag | ||
run: | | ||
if [[ "${{ github.ref }}" == *"-rc"* ]] || [[ "${{ github.ref }}" == *"-RC"* ]]; then | ||
echo "tag=next" >> "$GITHUB_OUTPUT" | ||
else | ||
echo "tag=latest" >> "$GITHUB_OUTPUT" | ||
fi | ||
|
||
# Install dependencies (if any) and build your project (if necessary) | ||
- name: Install dependencies and build | ||
run: | | ||
npm install | ||
npm run build | ||
|
||
# Publish to NPM with the appropriate tag | ||
- name: Publish | ||
run: npm publish --tag ${{ steps.release_tag.outputs.tag }} | ||
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -254,7 +254,7 @@ export class Account extends Service { | |
* | ||
* Add an authenticator app to be used as an MFA factor. Verify the | ||
* authenticator using the [verify | ||
* authenticator](/docs/references/cloud/client-web/account#verifyAuthenticator) | ||
* authenticator](/docs/references/cloud/client-web/account#updateMfaAuthenticator) | ||
* method. | ||
* | ||
* @param {AuthenticatorType} type | ||
|
@@ -279,8 +279,8 @@ export class Account extends Service { | |
* Verify Authenticator | ||
* | ||
* Verify an authenticator app after adding it using the [add | ||
* authenticator](/docs/references/cloud/client-web/account#addAuthenticator) | ||
* method. | ||
* authenticator](/docs/references/cloud/client-web/account#createMfaAuthenticator) | ||
* method. add | ||
* | ||
* @param {AuthenticatorType} type | ||
* @param {string} otp | ||
|
@@ -319,7 +319,7 @@ export class Account extends Service { | |
* @throws {AppwriteException} | ||
* @returns {Promise} | ||
*/ | ||
async deleteMfaAuthenticator<Preferences extends Models.Preferences>(type: AuthenticatorType, otp: string): Promise<Models.User<Preferences>> { | ||
async deleteMfaAuthenticator(type: AuthenticatorType, otp: string): Promise<{}> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also breaking change |
||
if (typeof type === 'undefined') { | ||
throw new AppwriteException('Missing required parameter: "type"'); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change, we need a higher version bump