-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: android tutorial #190
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes 😄
I just noticed. @loks0n C'mon set a good example, why no description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loks0n More comments <3
The Appwrite docs, just like Appwrite, is completely open sourced. | ||
This means, anyone can help improve them and add new guides and tutorials. | ||
{% only_dark %} | ||
![Create project screen](/images/docs/tutorials/dark/idea-tracker.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loks0n What does ideas tracker look like? Not like this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed for now will send you screenshot if you able to format it 🙏
…android-tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loks0n If you follow with the code till Main activity step, you'll get slapped with a kotlin.UninitializedPropertyAccessException: lateinit property account has not been initialized
Do you know what this is?
Edit: missing an init line account = AccountService(client);
in Appwrite.kt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @loks0n I know you're gonna hate me for this, but some simple error handling? When I do invalid email and stuff, how much code is it to throw a snackbar or something? |
@loks0n some of these lines, do you think we should add the comments above instead? Maybe even with a 👇 emoji in comment, it's difficult to see this on the side |
| userId | String | Yes | | ||
| title | String | Yes | | ||
| description | String | No | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loks0n missing some steps for permissions ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this for other tutorials. Do we want a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this for other tutorials. Do we want a screenshot?
Hmmm yeah I don't think so. We don't need screenshots, just let them know what permissions need to be added with a table, I'll copy to the other tutorials :)
Create a new collection with the following attributes: | ||
| Field | Type | Required | | ||
|-------------|--------|----------| | ||
| userId | String | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to also set permissions so users would only see their own ideas?
Rest works great! Final few comments I think. |
@loks0n some of these lines, do you think we should add the comments above instead? Maybe even with a 👇 emoji in comment, it's difficult to see this on the side done & done |
@loks0n Let me try this later this week, prio is community PRs right now. |
Your Render PR Server URL is https://appwrite-io-docker-pr-190.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmir92ect0pc73dpk6fg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made changes
implementation ("io.appwrite:sdk-for-android:4.0.0") | ||
``` | ||
|
||
In case you need to create OAuth 2 sessions in the future, the following activity needs to be added inside the `<application>` tag, along side the existing `<activity>` tags in your [AndroidManifest.xml](https://github.com/appwrite/playground-for-flutter/blob/master/android/app/src/main/AndroidManifest.xml). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this pointing to Flutter? @loks0n
} | ||
|
||
suspend fun logout() { | ||
account.deleteSession("current") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
account.deleteSession("current") | |
try { | |
account.deleteSession("current") | |
} catch (ex: AppwriteException) { | |
// Handle logout failure | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abnegate We're gonna avoid this for sake of brevity in this tutorial for now.
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
No description provided.