Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sharp #4

Merged
merged 0 commits into from
Oct 21, 2021
Merged

Update sharp #4

merged 0 commits into from
Oct 21, 2021

Conversation

aptomaKetil
Copy link

Update sharp from 0.26.1 to 0.29.1.

Changelog: https://sharp.pixelplumbing.com/changelog

I've had to revert the repository-setting in package.json to lovell/sharp, because they've started using https://www.npmjs.com/package/prebuild-install to download prebuilt binaries, and this lib relies on the repository setting.

Obviously, this is incredibly unmergeable, so I'll just force-push this branch to retain-profile whenever this is approved.

@aptomaKetil
Copy link
Author

Probably easier just to look at the commit list. Our three commits are at the top.

https://github.com/aptoma/sharp/commits/update-sharp

@martinj
Copy link

martinj commented Oct 20, 2021

I've had to revert the repository-setting in package.json to lovell/sharp, because they've started using https://www.npmjs.com/package/prebuild-install to download prebuilt binaries, and this lib relies on the repository setting.

Does this affect SHARP_DIST_BASE_URL in anyway?

@aptomaKetil
Copy link
Author

Checked the install scripts now. SHARP_DIST_BASE_URL is unaffected, however I still need to make some changes. The prebuild-install-script fetches prebuilt binaries for sharp, not libvips. Which means if we leave it to do its business, it'll fetch a prebuilt binary for sharp which does not include our CMYK-fix.

I will undo my change to the repo setting, and use their install scripts to create our own prebuilt binaries instead.

@aptomaKetil
Copy link
Author

Reverted the package.json change now.

@aptomaKetil
Copy link
Author

Added prebuild command to wiki: https://github.com/aptoma/sharp/wiki

@aptomaKetil aptomaKetil merged commit 5988a2d into retain-profile Oct 21, 2021
@martinj martinj deleted the update-sharp branch November 30, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants