Feature/basic implementation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Alaksiej Mialeška <mialeszkaalaksiej@gmail.com>
paveliam
reviewed
Sep 10, 2019
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Configurations/LoggerConfiguration.cs
Outdated
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Elements/Element.cs
Outdated
Show resolved
Hide resolved
paveliam
approved these changes
Sep 10, 2019
[skip ci]
…sic-implementation
DmitryBogatko
requested changes
Sep 11, 2019
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/Startup.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/Startup.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Applications/Startup.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Elements/ElementFactory.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Elements/ElementFinder.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/src/Aquality.Selenium.Core/Utilities/FileReader.cs
Show resolved
Hide resolved
...y.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ChromeApplication.cs
Show resolved
Hide resolved
...elenium.Core/tests/Aquality.Selenium.Core.Tests/Applications/Browser/ConditionalWaitTests.cs
Show resolved
Hide resolved
Aquality.Selenium.Core/tests/Aquality.Selenium.Core.Tests/Resources/settings.custom.json
Show resolved
Hide resolved
* Add tests for WinAppDriver and ElementFactory to resolve #5. Related to #6. Corrected Element's public interface * Update azure-pipelines.yml for Azure Pipelines use WinAppDriver task * Update azure-pipelines.yml for Azure Pipelines * replace calc application * Fixed ElementFactoryTests for new application * Feature/abstract application manager (#8) * Extract abstract ApplicationManager from WIndowsApp/ApplicationManager * reworked ApplicationManager for chrome app tests * Enhanced abstract ApplicationManager, add ability to provide custom dependencies. Create tests to ensure that ApplicationManager could have custom dependencies registered in container.
This was referenced Sep 12, 2019
Closed
DmitryBogatko
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a basic implementation of core functionality