Extracted configurations #21
Conversation
updated com.fasterxml.jackson.core to 2.10.2
…e' into Feature/11-LoggerConfiguration
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
# Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/main/java/aquality/selenium/core/application/AqualityServices.java # src/test/java/tests/logger/LoggerTests.java
…erConfiguration # Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/resources/TestSuite.xml
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
…Configuration # Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/java/tests/configurations/EnvConfigurationTests.java
# Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/java/tests/utilities/CustomSettingsFileTests.java # src/test/java/tests/utilities/SettingsFileTests.java # src/test/resources/TestSuite.xml # src/test/resources/settings.json # src/test/resources/settings.local.json
src/main/java/aquality/selenium/core/configurations/ILoggerConfiguration.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,5 @@ | |||
| package aquality.selenium.core.localization; | |||
|
|
|||
| public enum SupportedLanguage { | |||
|
|
||
| @Test | ||
| public void testShouldBePossibleToGetLanguageFromNewSettingsFile() { | ||
|
|
| } | ||
|
|
||
| @AfterMethod | ||
| public void after() { |
There was a problem hiding this comment.
not sure that this overriding of base class's method would work as expected
| public interface ILoggerConfiguration { | ||
|
|
||
| /** | ||
| * Gets language of the library. |
There was a problem hiding this comment.
maybe 'of the logger' instead of 'of the library.'?
|
|
||
| public class ElementCacheConfiguration implements IElementCacheConfiguration{ | ||
|
|
||
| private static final String JSON_PATH = "/elementCache/isEnabled"; |
There was a problem hiding this comment.
could you please rename as IS_ENABLED_PATH
| private SettingsFileUtil() { | ||
| } | ||
|
|
||
| public static Object getValueOrDefault(ISettingsFile settingsFile, String path, Object defaultValue) { |
There was a problem hiding this comment.
can we move this in the default method of interface to remove this utility class
| getNumberAction.run(); | ||
| } catch (Exception e) { | ||
| Assert.assertSame(e.getCause().getClass(), NumberFormatException.class); | ||
| Assert.assertTrue(e.getMessage().contains("NumberFormatException")); |
There was a problem hiding this comment.
is it necessary after first verification on exception type?
There was a problem hiding this comment.
I am not sure if nedded second assert. Type of exception should be NumberFormatException
| } | ||
|
|
||
| private long getTimeout(TIMEOUT timeout){ | ||
| return Long.valueOf(settingsFile.getValue("/timeouts/" + timeout.getKey()).toString()); |
There was a problem hiding this comment.
would not it be better to move "/timeouts/" in the enumeration to keep full jsonpath in the one place? and getKey can be renamed to getPath or something like that
|
Kudos, SonarCloud Quality Gate passed!
|
3 participants
PR Details
Related Issue Link:
#11
How Has This Been Tested
tests.configurations.EnvConfigurationTests
tests.configurations.ProfileConfigurationTests
tests.configurations.LoggerConfigurationTests
tests.configurations.TimeoutConfigurationTests
tests.configurations.RetryConfigurationTests
tests.configurations.ElementCacheConfigurationTests
Checklist