Skip to content

Feature #8: Localization services #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2020
Merged

Feature #8: Localization services #24

merged 5 commits into from
Jan 31, 2020

Conversation

mialeska
Copy link
Contributor

@mialeska mialeska commented Jan 30, 2020 •
edited
Loading

PR Details

Related Issue Link:

closes #8 , related to #23

How Has This Been Tested
Checklist
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mialeska mialeska self-assigned this Jan 30, 2020
knysh
knysh reviewed Jan 30, 2020
View reviewed changes
@mialeska
Merge branch 'master' into Feature/8-Localization-Services
57e3a7b 
# Conflicts:
#	src/main/java/aquality/selenium/core/application/AqualityModule.java
#	src/main/java/aquality/selenium/core/configurations/LoggerConfiguration.java
#	src/test/resources/TestSuite.xml
@mialeska
Complete LocalizationManagerTests, fixed resource files, extracted IL…
d465d0c 
…ocalizationModule
@mialeska mialeska requested a review from knysh January 30, 2020 16:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DmitryBogatko DmitryBogatko merged commit 68d9114 into master Jan 31, 2020
@mialeska mialeska deleted the Feature/8-Localization-Services branch January 31, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DmitryBogatko DmitryBogatko DmitryBogatko approved these changes

@knysh knysh knysh approved these changes

@arazantsau arazantsau Awaiting requested review from arazantsau

@paveliam paveliam Awaiting requested review from paveliam

Assignees

@mialeska mialeska

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Localization services

3 participants

@mialeska @DmitryBogatko @knysh