Extracted IConditionalWait #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated com.fasterxml.jackson.core to 2.10.2
…e' into Feature/11-LoggerConfiguration
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
# Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/main/java/aquality/selenium/core/application/AqualityServices.java # src/test/java/tests/logger/LoggerTests.java
…erConfiguration # Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/resources/TestSuite.xml
…Configuration # Conflicts: # src/test/java/tests/configurations/EnvConfigurationTests.java
…Configuration # Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/java/tests/configurations/EnvConfigurationTests.java
# Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java # src/test/java/tests/utilities/CustomSettingsFileTests.java # src/test/java/tests/utilities/SettingsFileTests.java # src/test/resources/TestSuite.xml # src/test/resources/settings.json # src/test/resources/settings.local.json
…nalWait # Conflicts: # src/main/java/aquality/selenium/core/application/AqualityModule.java
…nalWait # Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/test/java/tests/configurations/BaseProfileTest.java
# Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/test/java/tests/configurations/EnvConfigurationTests.java # src/test/java/tests/configurations/ProfileConfigurationTests.java # src/test/java/tests/utilities/SettingsFileTests.java # src/test/resources/TestSuite.xml
DmitryBogatko
requested changes
Jan 31, 2020
| waitForTrue(condition, timeoutConfiguration.getCondition(), timeoutConfiguration.getPollingInterval(), message); | ||
| return true; | ||
| } catch (TimeoutException e) { | ||
| return false; |
There was a problem hiding this comment.
please, refactor this as follow:
a. should return void
b. should not catch an exception
| * @param message Part of error message in case of Timeout exception | ||
| * @return true if the condition has been met during the timeout | ||
| */ | ||
| boolean waitForTrue(BooleanSupplier condition, String message); |
There was a problem hiding this comment.
void type should be here and docs should tell about exception
src/test/java/utils/TimeUtil.java
Outdated
|
|
||
| public class TimeUtil { | ||
|
|
||
| public static double getCurrentTimeInSeconds() { |
There was a problem hiding this comment.
move this method in the Timer class
# Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/main/java/aquality/selenium/core/localization/ILocalizationManager.java # src/main/java/aquality/selenium/core/localization/LocalizationManager.java # src/test/resources/TestSuite.xml updated IConditionalWait
mialeska
reviewed
Jan 31, 2020
src/main/java/aquality/selenium/core/waitings/IConditionalWait.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/main/java/aquality/selenium/core/localization/ILocalizationManager.java # src/main/java/aquality/selenium/core/localization/LocalizationManager.java # src/test/resources/TestSuite.xml updated IConditionalWait
mialeska
requested changes
Feb 3, 2020
src/main/java/aquality/selenium/core/waitings/ConditionalWait.java
Outdated
Show resolved
Hide resolved
src/main/java/aquality/selenium/core/waitings/ConditionalWait.java
Outdated
Show resolved
Hide resolved
src/main/java/aquality/selenium/core/waitings/ConditionalWait.java
Outdated
Show resolved
Hide resolved
src/main/java/aquality/selenium/core/waitings/ConditionalWait.java
Outdated
Show resolved
Hide resolved
src/main/java/aquality/selenium/core/waitings/IConditionalWait.java
Outdated
Show resolved
Hide resolved
mialeska
reviewed
Feb 3, 2020
src/main/java/aquality/selenium/core/waitings/ConditionalWait.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/main/java/aquality/selenium/core/localization/ILocalizationManager.java # src/main/java/aquality/selenium/core/localization/LocalizationManager.java # src/test/resources/TestSuite.xml updated IConditionalWait refactored tests for ConditionalWait
mialeska
approved these changes
Feb 3, 2020
DmitryBogatko
approved these changes
Feb 3, 2020
# Conflicts: # src/main/java/aquality/selenium/core/applications/AqualityModule.java # src/test/java/tests/configurations/EnvConfigurationTests.java # src/test/java/tests/configurations/ProfileConfigurationTests.java # src/test/resources/TestSuite.xml
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Related Issue Link:
#6
How Has This Been Tested
tests.waitings.ConditionalWaitTests
Checklist