Skip to content

Feature/9 element action retrier #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 3, 2020
Merged

Feature/9 element action retrier #26

merged 5 commits into from
Feb 3, 2020

Conversation

knysh
Copy link
Contributor

@knysh knysh commented Jan 31, 2020 •
edited
Loading

PR Details

#9

How Has This Been Tested

tests.utilities.ElementActionRetrierTests

Checklist
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

knysh added 2 commits January 31, 2020 12:30
@knysh
#9 added ElementActionRetrier + tests
4d94f90 
added IUtilitiesModule
@knysh
#9 removed using of DI in tests
210b79d 
combined configuration tests in one class
mialeska
mialeska requested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@mialeska mialeska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, resolve conficts

knysh added 3 commits February 3, 2020 15:05
@knysh
#9 fixed comments
6d99d94
@knysh
Merge branch 'master' into Feature/9-ElementActionRetrier
d55bd1a 
# Conflicts:
#	src/main/java/aquality/selenium/core/application/AqualityModule.java
#	src/test/resources/TestSuite.xml
@knysh
merge with master
d0e6b09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

DmitryBogatko
DmitryBogatko approved these changes Feb 3, 2020
View reviewed changes
@DmitryBogatko DmitryBogatko self-requested a review February 3, 2020 12:34
@knysh knysh merged commit 42af04b into master Feb 3, 2020
@knysh knysh deleted the Feature/9-ElementActionRetrier branch February 3, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mialeska mialeska mialeska approved these changes

@DmitryBogatko DmitryBogatko DmitryBogatko approved these changes

@arazantsau arazantsau Awaiting requested review from arazantsau

@paveliam paveliam Awaiting requested review from paveliam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knysh @DmitryBogatko @mialeska