Feature/12 element state provider #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrected CachedElementStateProvider and ElementFinder
mialeska
requested review from
Dinerville,
DmitryBogatko,
arazantsau,
knysh and
paveliam
DmitryBogatko
approved these changes
Feb 7, 2020
knysh
reviewed
Feb 10, 2020
| String timeoutString = timeout == null ? "" : String.format("of %1$s seconds", timeout); | ||
| String message = String.format( | ||
| "Element %1$s has not become %2$s after timeout %3$s", locator, conditionName.toUpperCase(), timeoutString); | ||
| Logger.getInstance().warn(message); |
There was a problem hiding this comment.
would you like to localize this message?
|
Kudos, SonarCloud Quality Gate passed!
|
knysh
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
implement ElementStateProvider, ElementCacheHandler and CachedElementStateProvider
Related Issue Link:
closes #12
How Has This Been Tested
Checklist