Implemented ElementFactory #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryBogatko
requested changes
Feb 10, 2020
src/main/java/aquality/selenium/core/elements/ElementFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/aquality/selenium/core/elements/ElementsCount.java
Outdated
Show resolved
Hide resolved
| * @return WebElement | ||
| */ | ||
| default RemoteWebElement getElement() { | ||
| return getElement(null); |
There was a problem hiding this comment.
what does initializing with null mean?
There was a problem hiding this comment.
it means that the timeout wasn't specified and we will use the default one
mialeska
requested review from
DmitryBogatko,
arazantsau,
knysh and
paveliam
|
Kudos, SonarCloud Quality Gate passed!
|
DmitryBogatko
approved these changes
Feb 10, 2020
knysh
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Related Issue Link:
Closes #15
How Has This Been Tested
Checklist