Feature/15 element #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/aquality/selenium/core/elements/interfaces/IElement.java # src/main/java/aquality/selenium/core/elements/interfaces/IElementSupplier.java # src/main/java/aquality/selenium/core/elements/interfaces/IParent.java # src/main/resources/localization/be.json # src/main/resources/localization/en.json # src/main/resources/localization/ru.json
mialeska
reviewed
Feb 12, 2020
| return Logger.getInstance(); | ||
| } | ||
|
|
||
| protected ElementState getElementState() { |
There was a problem hiding this comment.
do we need it to be public? we don't have it in dotnet
There was a problem hiding this comment.
it was in selenium-java
I am not sure, lets remove it
mialeska
reviewed
Feb 12, 2020
mialeska
approved these changes
Feb 12, 2020
DmitryBogatko
requested changes
Feb 13, 2020
DmitryBogatko
approved these changes
Feb 13, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
mialeska
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Related Issue Link:
closes #13
How Has This Been Tested
Checklist