Skip to content

Feature/45 add find child elements to element #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 22, 2020
Merged

Feature/45 add find child elements to element #51

merged 10 commits into from
May 22, 2020

Conversation

mialeska
Copy link
Contributor

@mialeska mialeska commented May 21, 2020 •
edited
Loading

PR Details

  • Implement FindChildElements functionality for ElementFactory and IElement.
  • Reworked locator generation in order to support non-web libraries, such as Appium, where javascript execution for xpath generation is not supported.
  • Add missed overloads to findElements.
  • Covered all methods by tests.
Related Issue Link:

closes #45

How Has This Been Tested
Checklist
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mialeska mialeska self-assigned this May 21, 2020
@mialeska mialeska changed the title Feature/45 add find child elements to i element Feature/45 add find child elements to element May 21, 2020
DmitryBogatko
DmitryBogatko reviewed May 21, 2020
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mialeska mialeska merged commit fc42830 into master May 22, 2020
@mialeska mialeska deleted the Feature/45-Add-FindChildElements-to-IElement branch May 22, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryBogatko DmitryBogatko DmitryBogatko approved these changes

@knysh knysh knysh approved these changes

@paveliam paveliam paveliam approved these changes

Assignees

@mialeska mialeska

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add List<IElement> findChildElements(...) method to IElement
4 participants
@mialeska @DmitryBogatko @knysh @paveliam