Skip to content

changed webdrivermanager dependency to use latest #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2020
Merged

changed webdrivermanager dependency to use latest #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15e3089
changed webdrivermanager dependency to use latest
Sep 10, 2020
f14fc57
fixed imports cause of chnaged in the webdrivermanager library
Sep 10, 2020
606dd4a
version of wdm to 4.2.0 instead of latest to avoid incompatibility af…
Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.github.aquality-automation</groupId>
<artifactId>aquality-selenium</artifactId>
<version>2.5.0</version>
<version>2.5.1</version>
<packaging>jar</packaging>
<name>Aquality Selenium</name>
<description>Library around Selenium WebDriver</description>
Expand Down Expand Up @@ -85,7 +85,7 @@
<dependency>
<groupId>io.github.bonigarcia</groupId>
<artifactId>webdrivermanager</artifactId>
<version>3.4.0</version>
<version>4.2.0</version>
</dependency>

<dependency>
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/aquality/selenium/browser/LocalBrowserFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import aquality.selenium.configuration.driversettings.IDriverSettings;
import aquality.selenium.core.localization.ILocalizedLogger;
import aquality.selenium.core.utilities.IActionRetrier;
import io.github.bonigarcia.wdm.Architecture;
import io.github.bonigarcia.wdm.WebDriverManager;
import io.github.bonigarcia.wdm.config.Architecture;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.edge.EdgeDriver;
Expand All @@ -32,19 +32,19 @@ protected RemoteWebDriver getDriver() {
Architecture systemArchitecture = driverSettings.getSystemArchitecture();
switch (browserName) {
case CHROME:
WebDriverManager.chromedriver().version(webDriverVersion).setup();
WebDriverManager.chromedriver().driverVersion(webDriverVersion).setup();
driver = getDriver(ChromeDriver.class, driverSettings.getCapabilities());
break;
case FIREFOX:
WebDriverManager.firefoxdriver().version(webDriverVersion).setup();
WebDriverManager.firefoxdriver().driverVersion(webDriverVersion).setup();
driver = getDriver(FirefoxDriver.class, driverSettings.getCapabilities());
break;
case IEXPLORER:
WebDriverManager.iedriver().architecture(systemArchitecture).version(webDriverVersion).setup();
WebDriverManager.iedriver().architecture(systemArchitecture).driverVersion(webDriverVersion).setup();
driver = getDriver(InternetExplorerDriver.class, driverSettings.getCapabilities());
break;
case EDGE:
WebDriverManager.edgedriver().version(webDriverVersion).setup();
WebDriverManager.edgedriver().driverVersion(webDriverVersion).setup();
driver = getDriver(EdgeDriver.class, driverSettings.getCapabilities());
break;
case SAFARI:
Expand All @@ -56,7 +56,7 @@ protected RemoteWebDriver getDriver() {
return driver;
}

private <T extends RemoteWebDriver> T getDriver(Class<T> driverClass, Capabilities capabilities) {
private <T extends RemoteWebDriver> T getDriver(Class<T> driverClass, Capabilities capabilities) {
try {
return driverClass.getDeclaredConstructor(Capabilities.class).newInstance(capabilities);
} catch (ReflectiveOperationException e) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/aquality/selenium/configuration/driversettings/DriverSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import aquality.selenium.core.localization.ILocalizationManager;
import aquality.selenium.core.logging.Logger;
import aquality.selenium.core.utilities.ISettingsFile;
import io.github.bonigarcia.wdm.Architecture;
import io.github.bonigarcia.wdm.config.Architecture;
import org.apache.commons.lang3.StringUtils;
import org.openqa.selenium.MutableCapabilities;
import org.openqa.selenium.PageLoadStrategy;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/aquality/selenium/configuration/driversettings/IDriverSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package aquality.selenium.configuration.driversettings;

import aquality.selenium.browser.BrowserName;
import io.github.bonigarcia.wdm.Architecture;
import io.github.bonigarcia.wdm.config.Architecture;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.PageLoadStrategy;

Expand Down