-
Notifications
You must be signed in to change notification settings - Fork 35
fixed issue with findElements method for elements in the specific state #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DmitryBogatko
merged 27 commits into
master
from
findelements-should-return-only-elements-in-state
Sep 3, 2019
Merged
fixed issue with findElements method for elements in the specific state #54
DmitryBogatko
merged 27 commits into
master
from
findelements-should-return-only-elements-in-state
Sep 3, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated test because of changes additionally added QuickStartExample and reference to it from README file pom updated with list of developers
mialeska
requested changes
Aug 27, 2019
seems that #53 should be closed then |
added additional waitForPageToLoad after search in QuickStart example corrected messages in dictionary to get more clean message
updated test of findElements updated QuickStartExample updated readme
mialeska
approved these changes
Aug 28, 2019
…ity-selenium-java into findelements-should-return-only-elements-in-state
mialeska
approved these changes
Aug 29, 2019
split assertion to get more informative message in case of failure
add ScreenResolutionUtility task
try to set FirefoxDriver to be x32
…elements-in-state' into findelements-should-return-only-elements-in-state
mialeska
approved these changes
Sep 3, 2019
DmitryBogatko
commented
Sep 3, 2019
src/test/java/aquality/selenium/utils/ElementActionRetrierTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated test because of changes
additionally added QuickStartExample and reference to it from README file
pom updated with list of developers