added fix with return type of environment value #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knysh
approved these changes
Sep 13, 2019
added 9 commits
September 13, 2019 18:01
updated tests with timer
updated tests with timer
knysh
approved these changes
Sep 16, 2019
mialeska
requested changes
Sep 16, 2019
| getBrowser().getDriver().findElement(By.id("not_exist_element")); | ||
| }catch (NoSuchElementException e){ | ||
| endTime = getCurrentTimeInSeconds(); | ||
| durationSample = new DurationSample(timer.duration(), waitTime, 3); |
There was a problem hiding this comment.
moved to class variable
| "Conditional should be true", Collections.singleton(IllegalArgumentException.class)); | ||
| } catch (org.openqa.selenium.TimeoutException e){ | ||
| double duration = timer.stop(); | ||
| DurationSample durationSample = new DurationSample(timer.duration(), waitForTimeoutCondition, 7); |
There was a problem hiding this comment.
7 is hardcoded 5 times in this class
There was a problem hiding this comment.
moved to class variable
| }, waitForTimeoutCondition, waitForTimeoutPolling, | ||
| "Conditional should be true", Collections.singleton(IllegalArgumentException.class)); | ||
| double duration = timer.stop(); | ||
| DurationSample durationSample = new DurationSample(timer.duration(), waitForTimeoutCondition, 0); |
There was a problem hiding this comment.
0 for deviation is set 4 times in this class, should it be a private method or a default value for this parameter?
There was a problem hiding this comment.
fixed: created new constructor with default deviation equal '0'
mialeska
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.