Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(poetry): skip dev dependencies #156

Merged

Conversation

Catminusminus
Copy link
Contributor

Currently, Trivy detects vulnerabilities in Poetry dev-dependencies.
This behavior is not consistent with that to Pipenv dev-dependencies, and skipping dev-dependencies is considered preferable.

This PR will prevent Trivy from detecting vulnerabilities in Poetry dev-dependency.

This resolves #38.

This commit prevents Trivy from detecting vulnerabilities in Poetry dev-dependency.
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks👍

@knqyf263 knqyf263 merged commit 299772f into aquasecurity:main Dec 8, 2022
@knqyf263
Copy link
Collaborator

knqyf263 commented Dec 8, 2022

Do you mind if opening a PR to bump the go-dep-parser version in Trivy?

@knqyf263
Copy link
Collaborator

knqyf263 commented Dec 8, 2022

@Catminusminus
Copy link
Contributor Author

Sure. I'm on it.

Sq34sy pushed a commit to Sq34sy/go-dep-parser that referenced this pull request Jul 28, 2023
Sq34sy pushed a commit to Sq34sy/go-dep-parser that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(poetry): skip dev dependencies
3 participants