feat: Add curl and jq to release image #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Jun 20, 2023
Dockerfile.release
Outdated
| curl \ | ||
| jq \ | ||
| wget \ | ||
| && rm /var/cache/apk/* |
There was a problem hiding this comment.
Can we not pass --no-cache? Or maybe I don't understand the motivation to clear the cache here.
There was a problem hiding this comment.
You are right... I thought the index would be downloaded multiple times, but it isn't. My change would only be helpful for multiple apk add statements, not for a single one.
There was a problem hiding this comment.
@simar7 Could you have a look?
simar7
approved these changes
Jul 6, 2023
This adds curl and jq to the release image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #548 - adds curl and jq to the release image.
The apk command is changed to download the index only one time. Afterwards the cache is cleared.